Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html_report: add report generation timestamp #487

Merged
merged 2 commits into from
Aug 24, 2022

Conversation

DavidKorczynski
Copy link
Contributor

Ref: #468

@DavidKorczynski
Copy link
Contributor Author

Screenshot from 2022-08-24 19-06-21

@Navidem
Copy link
Contributor

Navidem commented Aug 24, 2022

Screenshot from 2022-08-24 19-06-21

Nice!

@DavidKorczynski DavidKorczynski merged commit a246d77 into ossf:main Aug 24, 2022
@evverx
Copy link
Contributor

evverx commented Aug 25, 2022

Thanks! To judge from
Screenshot 2022-08-25 at 14 40 40
it seems to show dates only. I tend to generate a few reports and view them at the same time so I'd probably add %H:%M:%S there to make it easier to tell them apart. I can send a PR if it makes sense.

@DavidKorczynski
Copy link
Contributor Author

I tend to generate a few reports and view them at the same time so I'd probably add %H:%M:%S there to make it easier to tell them apart. I can send a PR if it makes sense.

If you find it useful to have the precise timestamp then I'd be happy to have it and accept the PR!

I was a bit on the fence about this the main thing was once I reviewed the code I thought we should add a timezone if displaying the precise timestamp. The timezone required an extract package and I wasn't entirely sure what the hours+sec would add from a user perspective as for local runs I use the counter on the corpus- dirs to identify "when it was run". That said, I don't have any strong opinion on this and am happy to accept precise timestamp without timezone too!

@evverx
Copy link
Contributor

evverx commented Aug 25, 2022

I reviewed the code I thought we should add a timezone if displaying the precise timestamp

That's a good point. I'd just probably go with UTC but as far as I can tell it wouldn't be consistent with other dates on OSS-Fuzz. Let's put this idea on hold :-)

I use the counter on the corpus- dirs to identify "when it was run"

I run FI in containers and forward ports to a VM where they are forwarded to a real machine :-) so in my case it's easier to memorize ports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants